Skip to content

[Color system] fix default topbar colors #2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2019
Merged

[Color system] fix default topbar colors #2240

merged 1 commit into from
Oct 4, 2019

Conversation

@danrosenthal
Copy link

@danrosenthal danrosenthal commented Oct 4, 2019

During #2225, I made a mistake and inverted the default colors for the TopBar. This wasn't caught in VRT since we don't have an example just using the default colors.

before after
Screen Shot 2019-10-04 at 10 22 09 AM Screen Shot 2019-10-04 at 10 22 22 AM

@danrosenthal danrosenthal added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Oct 4, 2019
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2019 •
edited
Loading

Results

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

Files modified2
Files potentially affected24

Details

All files potentially affected (total: 24)
🧩 src/components/ThemeProvider/tests/ThemeProvider.test.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/utilities/theme/utils.ts (total: 24)

Files potentially affected (total: 24)

This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

dleroux
dleroux approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@dleroux dleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@danrosenthal danrosenthal merged commit 02ac419 into master Oct 4, 2019
@danrosenthal danrosenthal deleted the fix-topbar-defaults branch October 4, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dleroux dleroux dleroux approved these changes

@tmlayton tmlayton Awaiting requested review from tmlayton

Assignees

No one assigned

Labels

🤖Skip Changelog Causes CI to ignore changelog update check.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danrosenthal @dleroux