[TextField] delete irrelevant default numeric-range props, prevent unconditional aria-invalid='false' #2339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
ghost
added
the
cla-needed
AlexCLeduc
changed the title
AlexCLeduc
force-pushed
the
textfield_remove_weird_default_props
branch
from
020cb8f to
d83980e
Compare
ghost
removed
the
cla-needed
AlexCLeduc
force-pushed
the
textfield_remove_weird_default_props
branch
from
630c18e to
8fe58ce
Compare
AlexCLeduc
changed the title
dleroux
reviewed
Dec 16, 2019
| const normalizedStep = step != null ? step : 1; | ||
| const normalizedMax = max != null ? max : Infinity; | ||
| const normalizedMin = min != null ? min : -Infinity; | ||
|
|
dleroux
reviewed
Dec 16, 2019
| const normalizedMin = min != null ? min : -Infinity; | ||
|
|
||
| const {unstableGlobalTheming = false} = useFeatures(); | ||
|
|
|
Thank you for doing this @AlexCLeduc! There was a conflict I tried to resolve using Github but it introduced formatting issues in ci. Ping me when those are updated and I'll approve. |
AlexCLeduc
force-pushed
the
textfield_remove_weird_default_props
branch
from
ed7d359 to
7621636
Compare
|
Thanks @dleroux! I've just rebased over master |
dleroux
approved these changes
Dec 17, 2019
|
🎉 Thanks for your contribution to Polaris React! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #2282. I made a single PR because it was one issue, but maybe it should be split in two
WHAT is this pull request doing?
max,min,stepso they no longer show up in markup unless explicitly passedaria-invalid="false"from being rendered when there is no error