[TextField] Should always have an aria-labelledby property

[LauraAubin]

Part of #795

WHY are these changes introduced?

If the text field does not have a prefix or suffix, then it doesn't have an aria-labelledby value. Since label is a required prop on TextField, we will always have an id to link to.

WHAT is this pull request doing?

Removing the check for an empty array since the labelledby property should have a value regardless if the TextField has a prefix or suffix.

How to 🎩

• Open up Storybook
• Go to the "Modal with primary action" example
• Inspect the modal's TextField
• The TextField should have an aria-labelledby matching the label element.

• Notice the label's id PolarisTextField2Label on the input.

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility
• Updated the component's README.md with documentation changes
• Tophatted documentation changes in the style guide
• For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

[github-actions]

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

Files modified	3
Files potentially affected	9

Details

All files potentially affected (total: 9)

• /src/components/Autocomplete/components/TextField/TextField.tsx
• /src/components/Autocomplete/Autocomplete.tsx
• /src/components/Filters/Filters.tsx
• /src/components/ResourceList/components/FilterControl/components/DateSelector/DateSelector.tsx
• /src/components/ResourceList/components/FilterControl/components/FilterValueSelector/FilterValueSelector.tsx
• /src/components/ResourceList/components/FilterControl/components/FilterCreator/FilterCreator.tsx
• /src/components/ResourceList/components/FilterControl/FilterControl.tsx
• /src/components/ResourceList/ResourceList.tsx
• /src/components/ResourceList/components/FilterControl/types.ts

📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🧩 src/components/TextField/TextField.tsx (total: 9)

Files potentially affected (total: 9)

• /src/components/Autocomplete/components/TextField/TextField.tsx
• /src/components/Autocomplete/Autocomplete.tsx
• /src/components/Filters/Filters.tsx
• /src/components/ResourceList/components/FilterControl/components/DateSelector/DateSelector.tsx
• /src/components/ResourceList/components/FilterControl/components/FilterValueSelector/FilterValueSelector.tsx
• /src/components/ResourceList/components/FilterControl/components/FilterCreator/FilterCreator.tsx
• /src/components/ResourceList/components/FilterControl/FilterControl.tsx
• /src/components/ResourceList/ResourceList.tsx
• /src/components/ResourceList/components/FilterControl/types.ts

🧩 src/components/TextField/tests/TextField.test.tsx (total: 0)

Files potentially affected (total: 0)

---

This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

[dleroux]

🎩 works great! Just thinking we should probably add a test for this. Coverage is fine but this is not covered. What do you think?

[LauraAubin]

Probably best to add a test so that this fix doesn't get accidentally changed in the future.

[dleroux]

🎉 but probably can add a changelog for this?

[dleroux]

🎉