Skip to content

Conversation

amrocha
Copy link
Contributor

@amrocha amrocha commented Dec 5, 2019

WHY are these changes introduced?

The styleguide is updating a lot of URLs

WHAT is this pull request doing?

Updating the docs to reference the new links so we can remove the redirects over there

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2019

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

No significant changes to src/**/*.tsx were detected.


This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

Copy link
Member

@AndrewMusgrave AndrewMusgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links don't see to be live. Do we need to merge a pr into the style guide in tandem with the next release?

@amrocha
Copy link
Contributor Author

amrocha commented Dec 9, 2019

Yeah, there's a PR here https://github.com/Shopify/polaris-styleguide/pull/3129 that needs to be merged before this can go out

@amrocha amrocha merged commit e8cdfec into master Jan 13, 2020
@amrocha amrocha deleted the update-doc-link branch January 13, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants