Skip to content

[Tabmeasurer] Converted to a functional component #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 13, 2020
Merged

[Tabmeasurer] Converted to a functional component #2535

merged 4 commits into from
Jan 13, 2020

Conversation

AndrewMusgrave
Copy link
Member

WHY are these changes introduced?

More context here

This open in a tab, will polish and request reviews after hack days.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2019 •
edited
Loading

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

Files modified3
Files potentially affected1

Details

All files potentially affected (total: 1)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🧩 src/components/Tabs/components/TabMeasurer/TabMeasurer.tsx (total: 1)

Files potentially affected (total: 1)

🧩 src/components/Tabs/components/TabMeasurer/tests/TabMeasurer.test.tsx (total: 0)

Files potentially affected (total: 0)

This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@AndrewMusgrave AndrewMusgrave requested a review from dleroux January 8, 2020 23:54
@AndrewMusgrave AndrewMusgrave marked this pull request as ready for review January 9, 2020 16:33
@AndrewMusgrave AndrewMusgrave requested review from chloerice and removed request for dleroux January 13, 2020 18:43
chloerice
chloerice approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@chloerice chloerice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 👀👍🚀

@AndrewMusgrave AndrewMusgrave merged commit f4874d5 into master Jan 13, 2020
@AndrewMusgrave AndrewMusgrave deleted the funcify-tabmeasurer branch January 13, 2020 19:23
@LauraAubin LauraAubin temporarily deployed to production January 16, 2020 16:22 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chloerice chloerice chloerice approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndrewMusgrave @chloerice @LauraAubin