Skip to content

Bring back some old type oddness in i18n to help a release #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2019
Merged

Bring back some old type oddness in i18n to help a release #2579

merged 1 commit into from
Dec 20, 2019

Conversation

BPScott
Copy link
Member

@BPScott BPScott commented Dec 20, 2019

Don't call toString() on the item in the replacements array as JS can
handle the casting fine itself. This accounts for people passing in a
key of undefined and TS not catching it in consuming apps

@BPScott
Bring back some old type oddness in i18n to help a release
2b37f03 
Don't call toString() on the item in the replacements array as JS can
handle the casting fine itself. This accounts for people passing in a
key of undefined and TS not catching it in consuming apps
@dleroux dleroux requested review from chloerice and dleroux December 20, 2019 18:55
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2019 •
edited
Loading

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

Files modified1
Files potentially affected102

Details

All files potentially affected (total: 102)
🧩 src/utilities/i18n/I18n.ts (total: 102)

Files potentially affected (total: 102)

This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@BPScott BPScott added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Dec 20, 2019
@BPScott
Copy link
Member Author

BPScott commented Dec 20, 2019

Gonna skip the unreleased.md entry for this PR and add it direct to the changelog when I cut the release

dleroux
dleroux approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@dleroux dleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing! 🙇

@BPScott BPScott merged commit 67809ed into master Dec 20, 2019
@BPScott BPScott deleted the i18n-fix-forward branch December 20, 2019 19:16
@BPScott BPScott mentioned this pull request Jan 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dleroux dleroux dleroux approved these changes

@chloerice chloerice Awaiting requested review from chloerice

Assignees

No one assigned

Labels

🤖Skip Changelog Causes CI to ignore changelog update check.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BPScott @dleroux