Skip to content

Conversation

AndrewMusgrave
Copy link
Member

@AndrewMusgrave AndrewMusgrave commented Jan 13, 2020

WHY are these changes introduced?

Because we love type safety

WHAT is this pull request doing?

Changing the extension to ts

@AndrewMusgrave AndrewMusgrave marked this pull request as ready for review January 13, 2020 20:50
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2020

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

No significant changes to src/**/*.tsx were detected.


This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@AndrewMusgrave AndrewMusgrave changed the title Converted the build test to typescript Converted /tests/build.test.ts typescript Jan 13, 2020
@AndrewMusgrave AndrewMusgrave merged commit 83698cd into master Jan 17, 2020
@AndrewMusgrave AndrewMusgrave deleted the build-test-to-ts branch January 17, 2020 21:40
@dleroux dleroux temporarily deployed to production January 27, 2020 13:38 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants