Skip to content

[DataTable] Fixed uncaught exception #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 28, 2020
Merged

[DataTable] Fixed uncaught exception #2672

merged 4 commits into from
Jan 28, 2020

Conversation

AndrewMusgrave
Copy link
Member

@AndrewMusgrave AndrewMusgrave commented Jan 27, 2020 •
edited
Loading

WHY are these changes introduced?

Noticed this while 🎩 another change in web. Link to bugsnag in linked issues

Screen Shot 2020-01-27 at 6 35 47 PM

WHAT is this pull request doing?

Add a check to make sure querySelector returns some nodes

How to 🎩

  • Build consumer to web and use these reproduction instructions

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2020 •
edited
Loading

🟢 No significant changes to src/**/*.tsx were detected.

@AndrewMusgrave AndrewMusgrave marked this pull request as ready for review January 28, 2020 00:05
@AndrewMusgrave AndrewMusgrave merged commit b2f5994 into master Jan 28, 2020
@AndrewMusgrave AndrewMusgrave deleted the uncaught-rightEdge branch January 28, 2020 22:13
@chloerice chloerice temporarily deployed to production January 30, 2020 17:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chloerice chloerice chloerice approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewMusgrave @chloerice