[Card] Change "Isis" in examples to "Oasis" #2677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
|
🟢 No significant changes to |
LauraAubin
approved these changes
Jan 28, 2020
|
Thanks Laura! I'll take care of that. |
LauraAubin
reviewed
Jan 28, 2020
Co-Authored-By: Laura Aubin <laura.aubin@shopify.com>
|
🎉 Thanks for your contribution to Polaris React! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Removes the term "Isis" from Card examples.
I know that when it's not capitalized it just means an Egyptian goddess, but I don't think that's a distinction that users should have to make.
WHAT is this pull request doing?
I simply changed "Isis" to "Oasis" in these examples, to stay on-theme.
🎩 checklist
README.mdwith documentation changesThis is just a content change.