Skip to content

[Modal] Fix container's width #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2020
Merged

[Modal] Fix container's width #2692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14dc800
Update Modal width
mickaelzhang Jan 31, 2020
0fc2c38
Update UNRELEASED.md
mickaelzhang Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

- Fixed `TrapFocus` stealing focus from other `TrapFocus`'s ([#2681](https://github.com/Shopify/polaris-react/pull/2681))
- Fixed focus state color on monochrome `Buttons` ([#2684](https://github.com/Shopify/polaris-react/pull/2684))
- Fixed container's width on `Modal` ([#2692](https://github.com/Shopify/polaris-react/pull/2692))

### Documentation

Expand Down
4 changes: 2 additions & 2 deletions src/components/Modal/components/Dialog/Dialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ $large-width: rem(980px);
left: 0;
display: flex;
flex-direction: column;
width: 100vw;
width: 100%;
max-height: calc(100vh - #{$vertical-spacing});
background: var(--p-surface, color('white'));
box-shadow: var(--p-modal-shadow, shadow(layer));
Expand Down Expand Up @@ -64,7 +64,7 @@ $large-width: rem(980px);

&.sizeLarge {
@include breakpoint-after(layout-width(page-with-nav)) {
max-width: calc(100vw - #{$horizontal-spacing});
max-width: calc(100% - #{$horizontal-spacing});
}

@include breakpoint-after($large-width + $horizontal-spacing) {
Expand Down