-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[ResourceList] Fix persistent Action on MouseOut #2742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🟢 This pull request modifies 4 files and might impact 2 other files. Details:All files potentially affected (total: 2)📄
|
089614a
to
58187e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM will come back later today for a tophat
58187e6
to
63a38c5
Compare
cc/ @chloerice |
); | ||
const wrapperDiv = resourceItem.find('div'); | ||
const className = 'ResourceItem selectable selectMode'; | ||
const focusClassName = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit but you could add each class name into an array and .join(' ')
for better readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually didn't need these in const.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
63a38c5
to
d2fd78c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first is expected. In a regular resource list clicking the element would navigate the user to that resource.
The second I can't reproduce. Maybe create a separate issue with steps since it's already on master.
); | ||
const wrapperDiv = resourceItem.find('div'); | ||
const className = 'ResourceItem selectable selectMode'; | ||
const focusClassName = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually didn't need these in const.
d2fd78c
to
0ca1c4f
Compare
WHY are these changes introduced?
Fixes #2727
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist
README.md
with documentation changes