-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Pagination] Fix sizing on small screens when they have tooltips #2747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.Button { | ||
width: 100%; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting a linting error because it's doing 3 levels of nesting. Anyone know a better way to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the span will get added inside the other component I think this is your best bet. Good job on explicitly adding the span in the prop, it avoids surprises.
🟢 This pull request modifies 3 files and might impact 3 other files. Details:All files potentially affected (total: 3)📄
|
8a9b4bd
to
c2899a7
Compare
const constructedPrevious = | ||
previousTooltip && hasPrevious ? ( | ||
<Tooltip content={previousTooltip}>{previousButton}</Tooltip> | ||
<Tooltip activatorWrapper="span" content={previousTooltip}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that you specify the wrapper!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c2899a7
to
3040843
Compare
WHY are these changes introduced?
Fixes #2745
WHAT is this pull request doing?
Properly styling the buttons even if there is a tooltip wrapper on one of them
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Make sure you resize your window to small width (mobile)
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist
README.md
with documentation changes