Skip to content

Conversation

@dleroux
Copy link
Contributor

@dleroux dleroux commented Mar 30, 2020

WHY are these changes introduced?

I noticed this while working on slides, so I fixed it. The shadow no longer has an impact on Chromium edge and Windows high contrast mode.

Screen Shot 2020-03-29 at 3 14 04 PM

WHAT is this pull request doing?

Adds an outline to Banner.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@dleroux dleroux force-pushed the banner-high-contrast branch from f10486a to 1c1bd31 Compare March 30, 2020 11:24
@dleroux dleroux requested a review from AndrewMusgrave March 30, 2020 11:25
@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2020

🟢 This pull request modifies 2 files and might impact 1 other files.

Details:
All files potentially affected (total: 1)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🎨 src/components/Banner/Banner.scss (total: 1)

Files potentially affected (total: 1)

Copy link
Member

@AndrewMusgrave AndrewMusgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't tophat but looks good to me

@dleroux dleroux force-pushed the banner-high-contrast branch from f9fede6 to 68e3f6f Compare May 6, 2020 11:27
@dleroux dleroux force-pushed the banner-high-contrast branch from 68e3f6f to ac0d1de Compare May 6, 2020 12:35
@dleroux dleroux merged commit 8eb4395 into master May 6, 2020
@dleroux dleroux deleted the banner-high-contrast branch May 6, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants