-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Tooltip] Remove content max-height #2908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
d2d1bbd to
3a01ea8
Compare
kyledurand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just make sure to rebase against the latest master. Looks like there's a conflict in unreleased.
Thanks for this 👍
sylvhama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c2d0989 to
7adf6e2
Compare
|
The build failed because of changes made in |
UNRELEASED.md
Outdated
| ### Enhancements | ||
|
|
||
| - Updated `Filters` to only show the "More filters" button if necessary ([#2856](https://github.com/Shopify/polaris-react/pull/2856)). | ||
| - Added utilities for parsing video duration (https://polaris.shopify.com/components/images-and-icons/video-thumbnail) ([#2725](https://github.com/Shopify/polaris-react/pull/2725)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be removed. It already exists in the changelog which is why your build is failing. You might need to remove this line and rebase again 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, something went wrong with my rebase. Just fixed it 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another conflict in UNRELEASED.md 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed again 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are very unlucky today there is again a conflict 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you want me to get this over the finish line @thayannevls
Happy to help, and sorry about all of the conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shioyama Yes 😢 I fixed again lol
@kyledurand Do you think we can already merge this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the CI is failing because of duplicate-changelog.test.js, let me know if I can help to fix that.
7adf6e2 to
d01d8e8
Compare
d01d8e8 to
39e1964
Compare
39e1964 to
a305167
Compare
|
@thayannevls it seems the CI has some problems, I will follow up with Polaris people to find a solution! |
|
🎉 Thanks for your contribution to Polaris React! |
WHY are these changes introduced?
Fixes #2869
WHAT is this pull request doing?
Increasing content and wrapper max-height to
500pxwhich is a great size for the tooltip in my opinion, If you guys don't consider this a good solution I'm open to change it.Before

After

How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx: