Skip to content

[Autocomplete.Combobox] Convert to functional component #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chloerice merged 11 commits into from
Apr 29, 2020
Merged

[Autocomplete.Combobox] Convert to functional component #2918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ed3916f
Fix auto id generation for combobox
genevieveluyt Apr 15, 2020
e0a2077
Don't use state for id
genevieveluyt Apr 15, 2020
de1ac69
Use type inference for state
genevieveluyt Apr 15, 2020
c68668c
Use useToggle hook
genevieveluyt Apr 15, 2020
9b3ac03
Cleanup syntax
genevieveluyt Apr 15, 2020
f2e496b
Remove tracking previous popover state
genevieveluyt Apr 15, 2020
786235f
Derive selectedOption from selectedIndex
genevieveluyt Apr 15, 2020
b3405e0
Some more cleanup
genevieveluyt Apr 17, 2020
c4d92fd
Better spacing
genevieveluyt Apr 27, 2020
74202a0
Add entry to changelog
genevieveluyt Apr 28, 2020
3975bd0
Merge branch 'master' into autocomplete-combobox-id
genevieveluyt Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,6 @@

### Code quality

- Converted `ComboBox` to a functional component ([#2918](https://github.com/Shopify/polaris-react/pull/2918))

### Deprecations
Loading