Change breakpoint for page title #3468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🟢 This pull request modifies 2 files and might impact 3 other files. Details:All files potentially affected (total: 3)🎨
|
alex-page
commented
Oct 13, 2020
| import type {ThumbnailProps} from '../../../../../Thumbnail'; | ||
| import {classNames} from '../../../../../../utilities/css'; | ||
| import {useFeatures} from '../../../../../../utilities/features'; | ||
| import {useMediaQuery} from '../../../../../../utilities/media-query'; |
There was a problem hiding this comment.
This hook allows React to change when the mobile menu icon shows. In this case we do not want to change the font size on this breakpoint, we want to change it on the smallest breakpoint.
dfmcphee
approved these changes
Oct 13, 2020
francinen
approved these changes
Oct 13, 2020
|
Yeah that is expected, before we had three title sizes and there should only be two. Thanks @francinen ✨ |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This is a part of https://github.com/Shopify/polaris-rails/issues/2182
WHAT is this pull request doing?
Changes the fontsize and breakpoints for the page title in the new design language.
🎩 checklist
README.mdwith documentation changes