Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UNRELEASED.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f

### Enhancements

Updated `Textfield` with a `type` of `number` to not render a spinner if step is set to `0` ([#3477](https://github.com/Shopify/polaris-react/pull/3477))

### Bug fixes

### Documentation
Expand Down
2 changes: 1 addition & 1 deletion src/components/TextField/TextField.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ export function TextField({
);

const spinnerMarkup =
type === 'number' && !disabled && !readOnly ? (
type === 'number' && step !== 0 && !disabled && !readOnly ? (
<Spinner
onChange={handleNumberChange}
onMouseDown={handleButtonPress}
Expand Down
14 changes: 14 additions & 0 deletions src/components/TextField/tests/TextField.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,20 @@ describe('<TextField />', () => {
expect(element.find(Spinner)).toHaveLength(0);
});

it('removes spinner buttons when type is number and step is 0', () => {
const spy = jest.fn();
const element = mountWithAppProvider(
<TextField
id="MyNumberField"
label="NumberField"
type="number"
step={0}
onChange={spy}
/>,
);
expect(element.find(Spinner)).toHaveLength(0);
});

it('increments by step when value, step, or both are float numbers', () => {
const spy = jest.fn();
const element = mountWithAppProvider(
Expand Down