[MediaCard] Update to accept ReactNode as title and optional primaryAction #3552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alex-page Could someone please review this pull request? |
|
Love this @devchris 👏. Just for shared context are there any examples of reasons you needed this flexibility? I see you added the |
alex-page
reviewed
Oct 23, 2020
Co-authored-by: Alex Page <alex@alexpage.com.au>
I was using it with a For the optional |
alex-page
reviewed
Oct 23, 2020
Co-authored-by: Alex Page <alex@alexpage.com.au>
BPScott
approved these changes
Oct 23, 2020
Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com>
|
@alex-page can this be merged please? 😊 |
|
🎉 Thanks for your contribution to Polaris React! |
sylvhama
pushed a commit
that referenced
this pull request
Mar 26, 2021
…ction (#3552) Co-authored-by: Alex Page <alex@alexpage.com.au> Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
To keep add more functionality to the MediaCard similar to what regular Cards are already doing. So far, MediaCards do not accept ReactNodes as a title. If you do, the console log throws a bunch of warnings that you shouldn't nest stuff in paragraphs.
Also, when using a MediaCard, you are forced to set a primaryAction. This is not always wanted behavior. Maybe you just want to display something.
WHAT is this pull request doing?
It allows the MediaCard title to accept a ReactNode. In addition, it makes the primaryAction optional.
🎩 checklist
README.mdwith documentation changes