Update sewing-kit and typescript #3566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
commented
Oct 26, 2020
| const onChangeInterval = () => { | ||
| if (interval > minInterval) interval -= decrementBy; | ||
| onChange(); | ||
| onChange(0); |
There was a problem hiding this comment.
Fixing up the types in Spinner highlighted that this was wrong - onChange should take a number as an argument. This is still not doing what we'd hope the code should do - holding the step buttons doesn't increment the value - but at least it is properly typed now. I briefly tried fixing this but didn't get it working. I think a proper fix would be better as a separate PR.
alex-page
approved these changes
Oct 26, 2020
|
Thanks @BPScott looks like there was some lint/test failures but the changes look good. |
BPScott
force-pushed
the
eslint-bump-investigation
branch
from
cb390df to
a29d374
Compare
- Cache buildinfo when running type-check (this was disallowed before)
BPScott
force-pushed
the
eslint-bump-investigation
branch
from
a29d374 to
e4d82d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Keeping up to date, prepping for the future
WHAT is this pull request doing?
Updates sewing-kit to 0.140.0
Updates typescript to 4.0.3
The typescript bump lets us cache TS type info when running type-checks without emiting any d.ts files - this means repeated runs of
yarn run type-checkare faster as it can use the cache. Repeated runs now take ~7s instead of ~20s).The SK update pulls us onto newest major versions of eslint 7.x and stylelint 13.7.x. In particular this means better support for optional chaining and we fix a few false positives in react hooks lints.
How to 🎩
Ensure tests pass