Skip to content

Update banner critical icon to use diamond #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2020
Merged

Update banner critical icon to use diamond #3567

merged 3 commits into from
Oct 27, 2020

Conversation

@alex-page
Copy link
Member

WHY are these changes introduced?

Fixes https://github.com/Shopify/polaris-ux/issues/478

Screen Shot 2020-10-27 at 9 28 00 AM

WHAT is this pull request doing?

New icon:

Screen Shot 2020-10-27 at 9 28 00 AM

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@alex-page alex-page self-assigned this Oct 27, 2020
@alex-page alex-page requested a review from kyledurand October 27, 2020 13:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2020 •
edited
Loading

🟢 No significant changes to src/**/*.tsx were detected.

kyledurand
kyledurand approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

@alex-page alex-page merged commit f2d9032 into master Oct 27, 2020
@alex-page alex-page deleted the banner-critical-icon-diamond branch October 27, 2020 17:19
sylvhama pushed a commit that referenced this pull request Mar 26, 2021
@sylvhama
Update banner critical icon to use diamond (#3567)
9f35c43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyledurand kyledurand kyledurand approved these changes

Assignees

@alex-page alex-page

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alex-page @kyledurand