Skip to content

[TextField] Add aria-expanded to TextField #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

[TextField] Add aria-expanded to TextField #3589

merged 1 commit into from
Oct 30, 2020

Conversation

@dleroux
Copy link
Contributor

@dleroux dleroux commented Oct 30, 2020 •
edited
Loading

WHY are these changes introduced?

The new aria 1.2 spec for combobox moved the aria-expanded prop to the Input. This allows for that.

How to 🎩

In a playground test the values of area-expanded, true or false, and ensure they render.

import React from 'react';
import {Page, TextField} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
     <TextField
            label="Store name"
            value=""
            ariaExpanded
    </Page>
  );
}

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2020 •
edited
Loading

🟡 This pull request modifies 3 files and might impact 9 other files. This is an average splash zone for a change, remember to tophat areas that could be affected.

Details:
All files potentially affected (total: 9)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🧩 src/components/TextField/TextField.tsx (total: 9)

Files potentially affected (total: 9)

🧩 src/components/TextField/tests/TextField.test.tsx (total: 0)

Files potentially affected (total: 0)

@dleroux dleroux requested a review from alex-page October 30, 2020 17:19
@dleroux dleroux changed the title [WIP][TextField] Add aria-expanded to TextField [TextField] Add aria-expanded to TextField Oct 30, 2020
@dleroux dleroux merged commit d98bdf0 into master Oct 30, 2020
@dleroux dleroux deleted the aria-expanded branch October 30, 2020 17:56
sylvhama pushed a commit that referenced this pull request Mar 26, 2021
@dleroux @sylvhama
added aria expanded (#3589)
9e18064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-page alex-page alex-page approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dleroux @alex-page