Skip to content

Conversation

@alex-page
Copy link
Member

@alex-page alex-page commented Nov 11, 2020

WHY are these changes introduced?

Fixes https://github.com/Shopify/web/issues/33665

WHAT is this pull request doing?

  • Center aligns the search clear button on iOS
  • Creates a bigger touch target
  • Retains the clear style in all other browsers and devices

How to 🎩

  1. dev up && dev s
  2. Open 192.168.0.11:6006 on an iOS device with safari
  3. Go to the details page and type into the search input
  4. Test in other browsers to make sure the clear button has no regressions

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@alex-page alex-page requested a review from kyledurand November 11, 2020 15:34
@alex-page alex-page self-assigned this Nov 11, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2020

🟢 This pull request modifies 2 files and might impact 2 other files.

Details:
All files potentially affected (total: 2)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🎨 src/components/TopBar/components/SearchField/SearchField.scss (total: 2)

Files potentially affected (total: 2)

Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 looks good in the sim 👍

@alex-page alex-page merged commit e792f96 into master Nov 11, 2020
@alex-page alex-page deleted the search-clear-button-ios branch November 11, 2020 17:59
kyledurand pushed a commit that referenced this pull request Nov 13, 2020
sylvhama pushed a commit that referenced this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants