Skip to content

Conversation

@lsit
Copy link
Contributor

@lsit lsit commented Mar 23, 2021

WHY are these changes introduced?

Resolves #4072

WHAT is this pull request doing?

  • Updates the default accessibility label of the RollupActions button to be "View actions" to better match our content guidelines
  • Updates the accessibility label of the RollupActions button within the Page header to be related to the title "View actions for {title}". This will provide consistency across all pages.
Media Screen Shot 2021-11-18 at 12 02 06 PM

How to 🎩

  • View the Page with all header elements story on small screen
  • Enable VoiceOver and tab to the "..." button or look at the Form Controls in the rotor

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@ghost
Copy link

ghost commented Mar 23, 2021

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2021

🟢 This pull request modifies 5 files and might impact 3 other files.

Details:
All files potentially affected (total: 3)
📄 locales/en.json (total: 0)

Files potentially affected (total: 0)

🧩 src/components/ActionMenu/ActionMenu.tsx (total: 2)

Files potentially affected (total: 2)

🧩 src/components/ActionMenu/components/Actions/Actions.tsx (total: 3)

Files potentially affected (total: 3)

🧩 src/components/ActionMenu/components/RollupActions/RollupActions.tsx (total: 3)

Files potentially affected (total: 3)

🧩 src/components/Page/components/Header/Header.tsx (total: 1)

Files potentially affected (total: 1)

@alex-page alex-page force-pushed the main branch 7 times, most recently from 2c6e842 to d2611d6 Compare June 11, 2021 16:24
@lsit lsit force-pushed the update-rollup-actions-accessibility-label branch from 12c8ef1 to f2f4941 Compare November 15, 2021 18:26
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2021

size-limit report

Path Size
cjs 166.18 KB (+0.04% 🔺)
esm 96.75 KB (+0.07% 🔺)
esnext 143.3 KB (+0.05% 🔺)
css 34.28 KB (0%)

@lsit lsit self-assigned this Nov 15, 2021
@lsit lsit added Accessibility Needs design, development, or content work relating to accessibility. Feature request labels Nov 15, 2021
@lsit lsit force-pushed the update-rollup-actions-accessibility-label branch from 794a70c to 43ce39f Compare November 15, 2021 20:30
@lsit lsit changed the title [WIP][Page] Update rollup actions accessibility label [WIP][Page] Improve the accessibility of the rollup actions Nov 15, 2021
@lsit lsit changed the title [WIP][Page] Improve the accessibility of the rollup actions [Page] Improve the accessibility of the rollup actions Nov 15, 2021
@lsit lsit marked this pull request as ready for review November 15, 2021 21:28
Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if the tooltip is 100% necessary because it's adding more clutter to the already cluttered page header the a11y label on button should be enough for screenreaders right? @sarahill do you have thoughts on this?

@lsit
Copy link
Contributor Author

lsit commented Nov 16, 2021

@kyledurand thanks for taking a look! Adding the tooltip was to help voice-command users as @emma-boardman described in this comment.

Copy link
Contributor

@emma-boardman emma-boardman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed review!

- Label overrides
I can't remember if this was discussed previously (apologies if it was), but is there a way to encourage consistency with the custom labels, and thus across the admin? For example, View actions for ${my-custom-label}?

- Tooltip
Agree this could look cluttered depending on the page in question 🤔

Maybe next time there's a design language iteration we could do some Fable testing and see if there's a way to better serve voice-activation users within our mobile UI.

@lsit lsit force-pushed the update-rollup-actions-accessibility-label branch 2 times, most recently from 382ed73 to e308d67 Compare November 18, 2021 16:39
@lsit lsit force-pushed the update-rollup-actions-accessibility-label branch from bb1251b to 79e3f3b Compare November 18, 2021 16:56
@lsit
Copy link
Contributor Author

lsit commented Nov 18, 2021

I've removed the tooltip and we can revisit that later, particularly because depending on hover is not a pattern we can use on mobile. I also updated the label to use the Page title if it's provided, which I think will provide good consistency across pages and should be descriptive enough. If we need more customization, we can add the prop back later as well.

I'll re-request the translation once approved.

@sarahill
Copy link
Contributor

➕ 1 to removing the tooltip for now. We're starting to look at things like this across the UI now so thanks for bringing this up. I will keep it in mind 👍

Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @lsit !

@lsit lsit force-pushed the update-rollup-actions-accessibility-label branch from 997a41b to d51e45d Compare November 22, 2021 19:30
@lsit lsit force-pushed the update-rollup-actions-accessibility-label branch from d51e45d to f40da47 Compare November 22, 2021 19:34
@lsit lsit merged commit e3b0bb1 into main Nov 22, 2021
@lsit lsit deleted the update-rollup-actions-accessibility-label branch November 22, 2021 19:42
@ghost
Copy link

ghost commented Nov 22, 2021

🎉 Thanks for your contribution to Polaris React!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessibility Needs design, development, or content work relating to accessibility. Feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Page] Add custom accessibility label to rolled up actions button

4 participants