[Test modernization] on TopBar components tests #4311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
ghost
force-pushed
the
polaris_topbar_tests
branch
3 times, most recently
from
f29f4ee to
d6809dd
Compare
ghost
force-pushed
the
polaris_topbar_tests
branch
from
d6809dd to
3075259
Compare
ghost
commented
Jul 14, 2021
| it('renders with the given props', () => { | ||
| const userMenu = mountWithAppProvider(<UserMenu {...userMenuProps} />); | ||
| expect(userMenu.find(UserMenu).props()).toStrictEqual(userMenuProps); | ||
| const userMenu = mountWithApp(<UserMenu {...userMenuProps} />); |
Author
There was a problem hiding this comment.
This is the only big change that I am doing, but not sure if this makes sense to test that the props are being render.
ghost
marked this pull request as ready for review
ghost
requested review from
a team,
AndrewMusgrave and
andrewmcgov
and removed request for
AndrewMusgrave
rdott
reviewed
Aug 9, 2021
rdott
reviewed
Aug 9, 2021
rdott
approved these changes
Aug 9, 2021
Contributor
rdott
left a comment
rdott
left a comment
There was a problem hiding this comment.
Couple of small comments, but otherwise it looks good!
alex-page
approved these changes
Aug 9, 2021
BPScott
approved these changes
Aug 9, 2021
Co-authored-by: Richard T <richard.todd@shopify.com>
Co-authored-by: Richard T <richard.todd@shopify.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
I am updating existing tests for Message, Menu, Search, SearchDismissOverlay, SearchField, UserMenu and TopBar components to use the new modern framework.
WHAT is this pull request doing?
Part of test modernization (https://docs.google.com/spreadsheets/d/1GBuEZbOpVYJLNISK7gL69DU8rCxocn5L5GYaKtPXPbU/edit#gid=1498187033), updating tests using {mountWithAppProvider} from 'test-utilities/legacy' to {mountWithApp} from 'test-utilities'.