[Test Modernization]: Card components #4325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
Contributor
size-limit report
|
alex-page
approved these changes
Jul 20, 2021
AndrewMusgrave
approved these changes
Jul 26, 2021
Member
AndrewMusgrave
left a comment
AndrewMusgrave
left a comment
There was a problem hiding this comment.
Left a couple comments about findAll but other than that, LGTM to me 💯
Comment on lines
155
to
156
| const buttons = card.findAll(Button); | ||
| expect(buttons[0].prop('children')).toBe('test action'); |
Member
There was a problem hiding this comment.
Curious why we're finding all but only using the first? It could be written as
const button = card.find(Button);
expect(button.prop('children')).toBe('test action');
or
Suggested change
| const buttons = card.findAll(Button); | |
| expect(buttons[0].prop('children')).toBe('test action'); | |
| expect(card).toContainReactComponent(Button, {children: 'test action'}); |
| expect(card.find(Popover).first()).toHaveLength(0); | ||
| const buttons = card.findAll(Button); | ||
| expect(buttons[0].prop('children')).toBe('test action'); | ||
| expect(card).not.toContainReactComponent(Popover); |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
I am updating existing tests for the following components in Card component to use the new modern framework:
WHAT is this pull request doing?
Part of test modernization (https://docs.google.com/spreadsheets/d/1GBuEZbOpVYJLNISK7gL69DU8rCxocn5L5GYaKtPXPbU/edit#gid=1498187033), updating tests using
{mountWithAppProvider} from 'test-utilities/legacy'to{mountWithApp} from 'test-utilities'.