Skip to content

Conversation

@danielle-dsouza
Copy link
Contributor

@danielle-dsouza danielle-dsouza commented Jul 27, 2021

WHY are these changes introduced?

Modernizes tests to use the new modern framework ({mountWithApp} from test-utilities).

WHAT is this pull request doing?

Updates tests using {mountWithAppProvider} from test-utilities/legacy to use {mountWithApp} from test-utilities

Note: Console Warning

The tests all pass but there is a warning in the terminal that I have not figured out how to clear.
Screen Shot 2021-07-27 at 4 58 58 PM

@github-actions
Copy link
Contributor

size-limit report

Path Size
cjs 142.12 KB (0%)
esm 95.85 KB (0%)
esnext 138.85 KB (0%)
css 33.56 KB (0%)

@danielle-dsouza danielle-dsouza marked this pull request as ready for review July 28, 2021 11:40
@danielle-dsouza danielle-dsouza requested a review from a team July 28, 2021 11:40
@danielle-dsouza danielle-dsouza merged commit 8dc4441 into main Aug 3, 2021
@danielle-dsouza danielle-dsouza deleted the polaris-tests branch August 3, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants