[TextField] Fix disabled text color in Safari

[kyledurand]

WHY are these changes introduced?

Fixes #182

WHAT is this pull request doing?

I think webkit overrides the color value of disabled inputs. We were using current color here before because I think legacy Polaris had different colors for different disabled states i.e. error. Now they're all using --p-text-disabled

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:

import React from 'react';

import {Page, TextField} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      <TextField
        disabled
        label="some value"
        value="some value"
        onChange={(value) => console.log(value)}
      />
    </Page>
  );
}

🎩 checklist

• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility
• Updated the component's README.md with documentation changes
• Tophatted documentation changes in the style guide
• For visual design changes, ping @ sarahill to update the Polaris UI kit

[github-actions]

size-limit report

Path	Size
cjs	142.12 KB (0%)
esm	95.85 KB (0%)
esnext	138.86 KB (+0.01% 🔺)
css	33.56 KB (+0.01% 🔺)

[nicolleromero]

LGTM! 🚀

[adriancorcoran]

Hey folks, sorry to block (not sure what your conventions are when reviewing :) ), but this is what I saw in Safari on desktop and mobile (all other browsers checked out ok):

Here's the exact list of steps I followed:

1. dev clone polaris-react

2. dev u

3. Added the following code to the playground/Playground.tsx file

   import React from 'react';
   
   import {Page, TextField} from '../src';
   
   export function Playground() {
     return (
       <Page title="Playground">
         <TextField
           disabled
           label="some value"
           value="some value"
           onChange={(value) => console.log(value)}
         />
       </Page>
     );
   }

4. yarn dev

5. go to http://192.168.86.105:6006/?path=/story/playground-playground--playground in Safari

Maybe I missed something? Let me know if I can help further :)

[kyledurand]

Looks like you might have missed git checkout text-field_fix-webkit-disabled-text-color If not then can you share the safari version you're using @adriancorcoran

[adriancorcoran]

Oh god how embarrassing!! :) New repo and tophatting procedure, sorry about that folks!

✅ We're all good