[Test Modernization]: Skeleton and Spinner tests #4353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
jwalk088
force-pushed
the
polaris-skeleton-test-mod
branch
from
b7efe0b to
d1abc8c
Compare
Contributor
size-limit report
|
jwalk088
force-pushed
the
polaris-skeleton-test-mod
branch
from
d1abc8c to
886284e
Compare
BPScott
approved these changes
Aug 9, 2021
alex-page
approved these changes
Aug 9, 2021
jwalk088
force-pushed
the
polaris-skeleton-test-mod
branch
from
886284e to
2168d49
Compare
|
🎉 Thanks for your contribution to Polaris React! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This updates the Skeleton and Spinner tests to use the new react-testing framework
WHAT is this pull request doing?
Updates tests using {mountWithAppProvider} from test-utilities/legacy to use {mountWithApp} from test-utilities