[Test modernization] Modernizes DatePicker, DescriptionList, DisplayText #4360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielle-dsouza
force-pushed
the
polaris-tests
branch
from
4bb42de to
9af6e40
Compare
Contributor
size-limit report
|
danielle-dsouza
changed the title
danielle-dsouza
force-pushed
the
polaris-tests
branch
from
9af6e40 to
eea61a7
Compare
danielle-dsouza
force-pushed
the
polaris-tests
branch
from
eea61a7 to
5d0a33d
Compare
danielle-dsouza
force-pushed
the
polaris-tests
branch
from
5d0a33d to
2f5af60
Compare
alex-page
approved these changes
Aug 26, 2021
rdott
reviewed
Aug 26, 2021
src/components/DatePicker/components/Month/tests/Month.test.tsx
Outdated
Show resolved
Hide resolved
rdott
approved these changes
Aug 26, 2021
Contributor
rdott
left a comment
rdott
left a comment
There was a problem hiding this comment.
I had the PR open so took a look for a review. LGTM
Just a nit suggestion for readability.
danielle-dsouza
force-pushed
the
polaris-tests
branch
from
2f5af60 to
ad37c72
Compare
danielle-dsouza
changed the title
danielle-dsouza
force-pushed
the
polaris-tests
branch
from
ad37c72 to
3f9c546
Compare
Member
|
The size-limit PR check is being a butt. I'll be investigating how to fix that up tomorrow. feel free to merge without it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
WHY are these changes introduced?
Modernizes tests to use the new modern framework (
{mountWithApp}fromtest-utilities).WHAT is this pull request doing?
Updates tests using
{mountWithAppProvider}fromtest-utilities/legacyto use{mountWithApp}fromtest-utilities