[TextField] Fully removed clear button when there is no text #4369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMusgrave
commented
Aug 9, 2021
Comment on lines
-235
to
-237
| &.ClearButton-hidden { | ||
| @include visually-hidden; | ||
| } |
Member
Author
There was a problem hiding this comment.
Is there a reason we need to hide the button rather than remove it? We could always add aria-hidden if so.
Contributor
size-limit report
|
AndrewMusgrave
force-pushed
the
fix-clear-button-without-text
branch
from
5ab336f to
3f7dc8d
Compare
dleroux
reviewed
Aug 10, 2021
dleroux
approved these changes
Aug 10, 2021
Co-authored-by: Daniel Leroux <dleroux@users.noreply.github.com>
lucabezerra
pushed a commit
that referenced
this pull request
Aug 16, 2021
* Fully removed clear button when there is no text * Fixed tests & added changelog * Update UNRELEASED.md Co-authored-by: Andrew Musgrave <AndrewMusgrave@users.noreply.github.com> Co-authored-by: Daniel Leroux <dleroux@users.noreply.github.com>
BPScott
pushed a commit
that referenced
this pull request
Aug 17, 2021
* Fully removed clear button when there is no text * Fixed tests & added changelog * Update UNRELEASED.md Co-authored-by: Andrew Musgrave <AndrewMusgrave@users.noreply.github.com> Co-authored-by: Daniel Leroux <dleroux@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This was noticed durning a bug hunt
WHAT is this pull request doing?
Removing the complexity around changing the clear buttons state so the clear button won't be visible to screen readers when the field is empty
Screenies
🎩 checklist
README.mdwith documentation changes