[Navigation.Item] Support selected prop for navigation items without url #4375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
mbensch
changed the title
mbensch
force-pushed
the
fix-nav-item-selected-prop
branch
from
4e1ca82 to
140f125
Compare
Member
|
It looks like the check may have stalled. If you push up your branch again they should re-run |
Update UNRELEASED.md
mbensch
force-pushed
the
fix-nav-item-selected-prop
branch
from
140f125 to
40ff793
Compare
Contributor
Author
|
Rebased and pushed. Hope all checks run this time. |
Contributor
size-limit report
|
Member
|
Github had degraded services yesterday, but it looks like everything is running now 🙌 |
|
🎉 Thanks for your contribution to Polaris React! |
lucabezerra
pushed a commit
that referenced
this pull request
Aug 16, 2021
- Support selected prop for navigation items without url - Update UNRELEASED.md
BPScott
pushed a commit
that referenced
this pull request
Aug 17, 2021
- Support selected prop for navigation items without url - Update UNRELEASED.md
CSilivestru
pushed a commit
that referenced
this pull request
Aug 25, 2021
- Support selected prop for navigation items without url - Update UNRELEASED.md
CSilivestru
pushed a commit
that referenced
this pull request
Aug 26, 2021
* Support selected prop for navigation items without url (#4375) - Support selected prop for navigation items without url - Update UNRELEASED.md * Allow subnav items to execute provided onClick handlers * Update UNRELEASED.md * Update tests to reflect number of called times * Removed outdated bug fix that is now in main Co-authored-by: Marcel Bensch <mbensch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #4244
Passing the
selectedprop toNavigation.Itemhad no effect if theurlprop was omitted.WHAT is this pull request doing?
Adds
Item-selectedclassname for items withouturlwhenselectedprop is true.