[Test Modernization] - Scrollable, ScrollTo, ScrollLock, Select, SettingToggle, Sheet, Spinner, and Sticky components #4386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdott
changed the title
ghost
approved these changes
Aug 12, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Looks good to me! I just left a question and I see that the CI is complaining around conflicts because this merge fest that we are having these days 🤪
| const element = mountWithApp( | ||
| <Select label="Select" options={[]} onBlur={spy} onChange={noop} />, | ||
| ); | ||
| element.find('select').simulate('focus'); |
Contributor
Author
There was a problem hiding this comment.
I don't think it's needed to focus on the event as we're just testing the callback when onBlur is triggered.
alex-page
approved these changes
Aug 12, 2021
Contributor
size-limit report
|
…ingToggle, Sheet, Spinner, and Sticky
lucabezerra
pushed a commit
that referenced
this pull request
Aug 16, 2021
…ingToggle, Sheet, Spinner, and Sticky components (#4386) * Select tests modernized * Test modernization for Scrollable, ScrollTo, ScrollLock, Select, SettingToggle, Sheet, Spinner, and Sticky
BPScott
pushed a commit
that referenced
this pull request
Aug 17, 2021
…ingToggle, Sheet, Spinner, and Sticky components (#4386) * Select tests modernized * Test modernization for Scrollable, ScrollTo, ScrollLock, Select, SettingToggle, Sheet, Spinner, and Sticky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Updating existing tests to use the new modern framework and eliminate stale dependencies.
For the following component tests:
WHAT is this pull request doing?
Part of test modernization, updating tests using
{mountWithAppProvider} from 'test-utilities/legacy'to{mountWithApp} from 'test-utilities'