[Test Modernization]: Add test modernization to CalloutCard, Caption, CheckableButton, Resizer, VideoThumbnail #4387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
ghost
changed the title
ghost
commented
Aug 11, 2021
src/components/TextField/components/Resizer/tests/Resizer.test.tsx
Outdated
Show resolved
Hide resolved
ghost
commented
Aug 12, 2021
| ); | ||
| element.find(Checkbox).first().simulate('click', { | ||
|
|
||
| element.find(Checkbox)!.find('input')!.trigger('onKeyUp', { |
Author
There was a problem hiding this comment.
This is another change, I am open for suggestions :)
Contributor
There was a problem hiding this comment.
My feeling is that there should be a test that checks that the function is passed to the Checkbox component, but not testing if it’s called, as this is already tested in Checkbox.test.tsx (As discussed on Slack)
ghost
marked this pull request as ready for review
alex-page
approved these changes
Aug 12, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
I am updating existing tests for CalloutCard, Caption, CheckableButton, Resizer, VideoThumbnail components to use the new modern framework.
WHAT is this pull request doing?
Part of test modernization (https://docs.google.com/spreadsheets/d/1GBuEZbOpVYJLNISK7gL69DU8rCxocn5L5GYaKtPXPbU/edit#gid=1498187033), updating tests using {mountWithAppProvider} from 'test-utilities/legacy' to {mountWithApp} from 'test-utilities'.