Skip to content

Conversation

@rdott
Copy link
Contributor

@rdott rdott commented Aug 11, 2021

WHY are these changes introduced?

Updating existing tests to use the new modern framework and eliminate stale dependencies.

For the following component tests:

  • Konami
  • Labelled
  • Link

WHAT is this pull request doing?

Part of test modernization, updating tests using {mountWithAppProvider} from 'test-utilities/legacy' to {mountWithApp} from 'test-utilities'

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2021

size-limit report

Path Size
cjs 142.51 KB (0%)
esm 96.27 KB (0%)
esnext 139.44 KB (0%)
css 33.74 KB (0%)

@rdott rdott force-pushed the test-mod/konami-code branch from 492ca87 to 7f3cf99 Compare August 11, 2021 21:18
@rdott rdott force-pushed the test-mod/konami-code branch from 410e23c to c4f39e2 Compare August 12, 2021 13:48
@rdott rdott changed the title [WIP][Test modernization] Konami, Labelled, Link, Layout, MediaCard, Tabs [WIP][Test modernization] Konami, Labelled, Link Aug 12, 2021
@rdott rdott changed the title [WIP][Test modernization] Konami, Labelled, Link [Test modernization] Konami, Labelled, Link Aug 12, 2021
@rdott rdott marked this pull request as ready for review August 12, 2021 17:57
@rdott rdott requested review from a team August 12, 2021 17:57
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 We are crushing these tests!

@rdott rdott merged commit 50dee4a into main Aug 12, 2021
@rdott rdott deleted the test-mod/konami-code branch August 12, 2021 18:20
lucabezerra pushed a commit that referenced this pull request Aug 16, 2021
* Modernized tests and removed testIds

* Added tests modernized to UNRELEASED.md

* Removed unused testId

* Split PR, removing Layout, MediaCard and Tabs tests
BPScott pushed a commit that referenced this pull request Aug 17, 2021
* Modernized tests and removed testIds

* Added tests modernized to UNRELEASED.md

* Removed unused testId

* Split PR, removing Layout, MediaCard and Tabs tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants