[Test Modernization] ContextualSaveBar and DataTable components #4397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
Contributor
size-limit report
|
laucindy
force-pushed
the
test-modernization-data-table-and-save-bar
branch
from
e2f6392 to
b641a1e
Compare
chloerice
approved these changes
Aug 16, 2021
rdott
reviewed
Aug 18, 2021
rdott
approved these changes
Aug 18, 2021
Contributor
rdott
left a comment
rdott
left a comment
There was a problem hiding this comment.
One small nit, otherwise LGTM!
alex-page
approved these changes
Aug 19, 2021
laucindy
force-pushed
the
test-modernization-data-table-and-save-bar
branch
from
b641a1e to
7bdbf75
Compare
Member
|
We think we've fixed up the gc out of memory errors by updating to TS 4.3, can you rebase and see if CI is happier now? |
…Navigation & DataTable)
laucindy
force-pushed
the
test-modernization-data-table-and-save-bar
branch
from
7bdbf75 to
3570f01
Compare
|
🎉 Thanks for your contribution to Polaris React! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Update existing tests for the following components to use the new modern framework:
WHAT is this pull request doing?
Part of test modernization, updating tests to use
{mountWithApp} from 'test-utilities', instead of{mountWithAppProvider} from 'test-utilities/legacy'