Skip to content

[Test Modernization] Switch to using mountWithApp on ResourceItem and ResourceList tests. v2 #4398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Aug 31, 2021
Merged

[Test Modernization] Switch to using mountWithApp on ResourceItem and ResourceList tests. v2 #4398

merged 19 commits into from
Aug 31, 2021

Conversation

@lucabezerra
Copy link
Contributor

@lucabezerra lucabezerra commented Aug 16, 2021

WHY are these changes introduced?

Modernizes tests to use the new modern framework ({mountWithApp} from test-utilities).

WHAT is this pull request doing?

Updates tests using {mountWithAppProvider} from test-utilities/legacy to use {mountWithApp} from test-utilities

@lucabezerra lucabezerra changed the base branch from main to v7.0.0-release August 16, 2021 18:51
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2021 •
edited
Loading

size-limit report

Path Size
cjs 163.42 KB (-0.04% 🔽)
esm 96.16 KB (-0.05% 🔽)
esnext 142.99 KB (-0.05% 🔽)
css 34.47 KB (0%)

@lucabezerra lucabezerra force-pushed the resourceitem-modernize-tests-v2 branch from 3f1006d to 92b615b Compare August 16, 2021 19:09
Base automatically changed from v7.0.0-release to main August 26, 2021 21:05
@lucabezerra lucabezerra marked this pull request as ready for review August 30, 2021 15:34
@lucabezerra lucabezerra requested a review from a team August 30, 2021 15:34
@lucabezerra lucabezerra mentioned this pull request Aug 30, 2021
Closed
kyledurand
kyledurand approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Looking good! ✨

@lucabezerra lucabezerra merged commit 3b9e63a into main Aug 31, 2021
@lucabezerra lucabezerra deleted the resourceitem-modernize-tests-v2 branch August 31, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyledurand kyledurand kyledurand approved these changes

@alex-page alex-page alex-page approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucabezerra @kyledurand @alex-page