Migrate to use sewing-kit-next for lint and test runs #4402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under the hood, we've updated from jest 25 to 27. We also update from babel 7.12 to 7.15, and @shopify/babel-plugin now uses the latest version. Currently skn does not provide out-the-box config jest transformers for scss and image files, so create them ourselves for now.
If you dedupe then enzyme gets confused and can't find an element by its name if it is wrapped in a forwardRef and a memo (it's UnstyledLink that does this) and then tests start failing
Contributor
size-limit report
|
alex-page
approved these changes
Aug 19, 2021
alex-page
pushed a commit
that referenced
this pull request
Aug 25, 2021
Under the hood, we've updated from jest 25 to 27. We also update from babel 7.12 to 7.15, and @shopify/babel-plugin now uses the latest version. Currently skn does not provide out-the-box config jest transformers for scss and image files, so create them ourselves for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
sewing-kit was never great for libraries. sewing-kit-next is better.
Eventually I want to use skn for build output (it uses rollup under the hood same as polaris's existing build), but the first step to that is configuring skn for test and linting runs.
WHAT is this pull request doing?
Replace sewing-kit with sewing-kit-next.
Under the hood, we've updated from jest 25 to 27.
We also updated from babel 7.12 to 7.15, and @shopify/babel-plugin now uses the latest version.
This PR ignores a few test cases that trigger circular dependency errors. I figure we can come back to them.
Currently skn does not provide out-the-box config jest transformers for scss and image files, so create them ourselves for now.
How to 🎩
@babel/plugin-transform-react-constant-elementsinlining components more.