[TestModernization]: Add test modernization to UnstyledLink, Tag, DisplayText, FileUpload, MessageIndicator, Choice and Dialog #4407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
ghost
ghost
changed the title
rdott
reviewed
Aug 19, 2021
src/components/DropZone/components/FileUpload/tests/FileUpload.test.tsx
Outdated
Show resolved
Hide resolved
rdott
reviewed
Aug 19, 2021
| const spy = jest.fn(); | ||
|
|
||
| const dialog = mountWithApp( | ||
| <Dialog labelledBy="test" onClose={jest.fn()} onEntered={spy}> |
Contributor
There was a problem hiding this comment.
Does onClose need to be mocked here? Could this be the following (just to match with the patterns in other tests)?
onClose={noop}Adding a
function noop() {}To the end of the test file?
Author
There was a problem hiding this comment.
I was thinking that, but because it is not needed on the test, I thought to leave it like it. But I can add the noop one!
rdott
approved these changes
Aug 19, 2021
Contributor
rdott
left a comment
rdott
left a comment
There was a problem hiding this comment.
Looks good.
Couple of small (non-blocking) suggestions.
🎉
alex-page
approved these changes
Aug 23, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
I am updating existing tests for UnstyledLink, Tag, DisplayText, FileUpload, MessageIndicator, Choice and Dialog components to use the new modern framework.
Thanks @rdott for the suggestion on the tag tests!
WHAT is this pull request doing?
Part of test modernization (https://docs.google.com/spreadsheets/d/1GBuEZbOpVYJLNISK7gL69DU8rCxocn5L5GYaKtPXPbU/edit#gid=1498187033), updating tests using {mountWithAppProvider} from 'test-utilities/legacy' to {mountWithApp} from 'test-utilities'.