Skip to content

Conversation

@alololox
Copy link
Contributor

@alololox alololox commented Aug 18, 2021

WHY are these changes introduced?

Within web we have a use case where a full progress bar is indicative of a critical event that requires immediate action:

Screen Shot 2021-08-18 at 9 35 34 AM

WHAT is this pull request doing?

This PR adds the Interactive/Critical color to the ProgressBar component

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      <ProgressBar progress={70} color="critical" />
    </Page>
  );
}

🎩 checklist

@alololox alololox self-assigned this Aug 18, 2021
@alololox alololox force-pushed the progressbar/critical-state branch from e4facf4 to 2a88247 Compare August 18, 2021 16:37
@alololox alololox marked this pull request as ready for review August 18, 2021 16:37
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2021

size-limit report

Path Size
cjs 142.53 KB (+0.01% 🔺)
esm 96.29 KB (+0.02% 🔺)
esnext 139.5 KB (+0.03% 🔺)
css 33.76 KB (+0.06% 🔺)

@alololox alololox merged commit a85b324 into main Aug 18, 2021
@alololox alololox deleted the progressbar/critical-state branch August 18, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants