Skip to content

Conversation

@rdott
Copy link
Contributor

@rdott rdott commented Aug 19, 2021

WHY are these changes introduced?

Updating existing tests to use the new modern framework and eliminate stale dependencies.

For the following component tests:

  • DropZone
  • ExceptionList
  • ConnectedFilterControl/Item

WHAT is this pull request doing?

Part of test modernization, updating tests using {mountWithAppProvider} from 'test-utilities/legacy' to {mountWithApp} from 'test-utilities'

@rdott rdott force-pushed the test-mod/dropzone branch from a056e9f to 5bbe2f1 Compare August 19, 2021 17:43
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2021

size-limit report

Path Size
cjs 143.11 KB (0%)
esm 96.81 KB (0%)
esnext 140.11 KB (0%)
css 33.96 KB (0%)

@rdott rdott changed the title [Test Modernization]: Modernized tests for Dropzone, EmptySearchResult, EmptyState, EventListener, ExceptionList, Item [Test Modernization]: Modernized tests for EmptySearchResult, EmptyState, EventListener, ExceptionList, Item Aug 19, 2021
@rdott rdott force-pushed the test-mod/dropzone branch 2 times, most recently from 6e52b24 to bf802e7 Compare August 23, 2021 18:21
@rdott rdott changed the title [Test Modernization]: Modernized tests for EmptySearchResult, EmptyState, EventListener, ExceptionList, Item [Test Modernization]: Modernized tests for DropZone, ExceptionList, Item Aug 23, 2021
@rdott rdott marked this pull request as ready for review August 23, 2021 20:41
@rdott rdott requested review from a user August 23, 2021 20:42
@rdott rdott requested review from a team and removed request for a team August 26, 2021 13:22
@rdott rdott force-pushed the test-mod/dropzone branch from ff828a3 to 4b443fd Compare August 26, 2021 18:58
@rdott rdott merged commit d80f43c into main Aug 26, 2021
@rdott rdott deleted the test-mod/dropzone branch August 26, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants