Update ts and storybook #4414
Merged
Update ts and storybook #4414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
kyledurand
force-pushed
the
update-ts-storybook
branch
from
3498e0a to
ce56a90
Compare
Member
|
Looks like @lucabezerra just modernised the icon/image tests too in #4418. Perhaps we merge that PR, then rebase this? |
kyledurand
force-pushed
the
update-ts-storybook
branch
from
ce56a90 to
21cfd1d
Compare
BPScott
approved these changes
Aug 23, 2021
Member
BPScott
left a comment
BPScott
left a comment
There was a problem hiding this comment.
I haven't ran storybook locally as I'm in the middle of a load of other stuff but if CI is happy then I'm happy
Add a changelog entry for the Icon behaviour change, address the test comment down below then 
kyledurand
force-pushed
the
update-ts-storybook
branch
from
21cfd1d to
f37d6b6
Compare
kyledurand
force-pushed
the
update-ts-storybook
branch
from
f37d6b6 to
2e29b85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4415
This will hopefully unblock PRs that are currently failing CI.