Skip to content

Conversation

@rdott
Copy link
Contributor

@rdott rdott commented Aug 23, 2021

WHY are these changes introduced?

Updating existing tests to use the new modern framework and eliminate stale dependencies.

For the following component tests:

  • EventListener
  • EmptySearchResult

WHAT is this pull request doing?

Part of test modernization, updating tests using {mountWithAppProvider} from 'test-utilities/legacy' to {mountWithApp} from 'test-utilities'

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2021

size-limit report

Path Size
cjs 142.64 KB (0%)
esm 96.38 KB (0%)
esnext 139.59 KB (0%)
css 33.77 KB (0%)

@rdott rdott changed the title [Test Modernization]: Modernized tests for EventListener [Test Modernization]: Modernized tests for EventListener, EmptySearchResult Aug 23, 2021
@rdott rdott requested a review from a team August 24, 2021 13:55
@rdott rdott requested a review from a user August 24, 2021 15:07
@rdott rdott marked this pull request as ready for review August 24, 2021 15:17
@rdott rdott merged commit d5ce409 into main Aug 24, 2021
@rdott rdott deleted the test-mod/eventlistener branch August 24, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants