Remove the esnext folder #4425
Merged
Remove the esnext folder #4425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
force-pushed
the
remove-esnext-folder
branch
from
acf4a66 to
a6bf6ae
Compare
Contributor
size-limit report
|
BPScott
force-pushed
the
remove-esnext-folder
branch
from
a6bf6ae to
40a7a7b
Compare
This folder was a relic from a time before sewing-kit supported reading esnext entrypoints from the `esnext` key in package.json, which was added in sewing-kit 0.135.0 (released Aug 2020). The configuration that forced sewing-kit to always read from this folder (instead of looking at the esnext entrypoint) was removed in Shopify/sewing-kit#2566 and released as sewing-kit 0.152.0 (released Mar 2021). If you are building an app using sewing-kit, you must use sewing-kit 0.152.0 or newer if you want esnext build support.
BPScott
force-pushed
the
remove-esnext-folder
branch
from
40a7a7b to
a56f751
Compare
kyledurand
approved these changes
Aug 24, 2021
alex-page
pushed a commit
that referenced
this pull request
Aug 25, 2021
This folder was a relic from a time before sewing-kit supported reading esnext entrypoints from the `esnext` key in package.json, which was added in sewing-kit 0.135.0 (released Aug 2020). The configuration that forced sewing-kit to always read from this folder (instead of looking at the esnext entrypoint) was removed in Shopify/sewing-kit#2566 and released as sewing-kit 0.152.0 (released Mar 2021). If you are building an app using sewing-kit, you must use sewing-kit 0.152.0 or newer if you want esnext build support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Removing legacy configuration.
WHAT is this pull request doing?
Removing the esnext folder.
The esnext folder was a relic from a time before sewing-kit supported reading
esnext entrypoints from the
esnextkey in package.json, which wasadded in sewing-kit 0.135.0 (released Aug 2020).
The configuration that forced sewing-kit to always read from this folder (instead of looking at the esnext entrypoint) was removed in Shopify/sewing-kit#2566 and released as sewing-kit 0.152.0 (released Mar 2021).
If you are building an app using sewing-kit, you must use sewing-kit 0.152.0 or newer if you want esnext build support.