[Test Modernization]: Modernized tests for EmptyState component #4427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
rdott
force-pushed
the
test-mod/emptystate
branch
from
7e96081 to
9f0ee0f
Compare
alex-page
approved these changes
Aug 25, 2021
LauraAubin
reviewed
Aug 26, 2021
UNRELEASED.md
Outdated
| - Modernized tests for EventListener and EmptySearch components([#4423](https://github.com/Shopify/polaris-react/pull/4423)) | ||
| - Modernized tests for Pane, Section, PositionedOverlay, SingleThumb, RangeSlider, and ConnectedFilter components ([#4429](https://github.com/Shopify/polaris-react/pull/4429)) | ||
| - Modernized tests for ContextualSaveBar and DataTable and its subcomponents ([#4397](https://github.com/Shopify/polaris-react/pull/4397)) | ||
| - Modernized tests for EmptyState component ([#](https://github.com/Shopify/polaris-react/pull/)) |
Contributor
There was a problem hiding this comment.
Suggested change
| - Modernized tests for EmptyState component ([#](https://github.com/Shopify/polaris-react/pull/)) |
Contributor
Author
There was a problem hiding this comment.
lol, thanks for catching that, I had it in as a placeholder until I actually made the PR 🙏
LauraAubin
approved these changes
Aug 26, 2021
Contributor
LauraAubin
left a comment
LauraAubin
left a comment
There was a problem hiding this comment.
One extra entry in the unreleased file, other than that LGTM ✨
rdott
force-pushed
the
test-mod/emptystate
branch
from
a66f731 to
fdeb76c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Updating existing tests to use the new modern framework and eliminate stale dependencies.
For the following component tests:
WHAT is this pull request doing?
Part of test modernization, updating tests using
{mountWithAppProvider} from 'test-utilities/legacy'to{mountWithApp} from 'test-utilities'