[Test Modernization]: Modernized tests for Pane, Section, PositionedOverlay, SingleThumb, ... #4429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
alex-page
approved these changes
Aug 24, 2021
debchn
approved these changes
Aug 25, 2021
Contributor
debchn
left a comment
debchn
left a comment
There was a problem hiding this comment.
2 nits, one question that also applies to the old test. None blocking. Thanks for doing this!
Comment on lines
+116
to
+118
| expect(positionedOverlay).toContainReactComponent('div', { | ||
| style: expect.objectContaining({left: 0, right: undefined}), | ||
| }); |
Contributor
There was a problem hiding this comment.
This reads so much better 👏
|
|
||
| expect(expected).toStrictEqual(actual || {}); | ||
| expect(element).toContainReactComponent('div', { | ||
| style: expect.objectContaining(expected) || {}, |
Contributor
There was a problem hiding this comment.
Do you know what's going on here? Why expected || {} -- shouldn't it just be expected?
Contributor
Author
There was a problem hiding this comment.
Yeah looking back at it I think you're right, there's no reason to expect anything else.
…angeSlider and ConnectedFilter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...RangeSlider and ConnectedFilter
WHY are these changes introduced?
Updating existing tests to use the new modern framework and eliminate stale dependencies.
For the following component tests:
WHAT is this pull request doing?
Part of test modernization, updating tests using
{mountWithAppProvider} from 'test-utilities/legacy'to{mountWithApp} from 'test-utilities'