Skip to content

Conversation

@rdott
Copy link
Contributor

@rdott rdott commented Aug 24, 2021

WHY are these changes introduced?

Updating existing tests to use the new modern framework and eliminate stale dependencies.

For the following component tests:

  • PopoverOverlay

WHAT is this pull request doing?

Part of test modernization, updating tests using {mountWithAppProvider} from 'test-utilities/legacy' to {mountWithApp} from 'test-utilities'

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2021

size-limit report

Path Size
cjs 143.11 KB (0%)
esm 96.81 KB (0%)
esnext 140.11 KB (0%)
css 33.96 KB (0%)

@rdott rdott force-pushed the test-mod/popoverlay branch from f6bfe0e to 063f8ab Compare August 25, 2021 19:42
@rdott rdott requested review from a user and kyledurand August 26, 2021 13:54
@rdott rdott force-pushed the test-mod/popoverlay branch from 73d8fd6 to d0bff5f Compare August 26, 2021 13:55
@rdott rdott marked this pull request as ready for review August 26, 2021 13:55
Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 I think you are ahead now!

@rdott rdott force-pushed the test-mod/popoverlay branch from d0bff5f to 52b1226 Compare August 26, 2021 17:31
@rdott rdott merged commit 5787880 into main Aug 26, 2021
@rdott rdott deleted the test-mod/popoverlay branch August 26, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants