Skip to content

Conversation

@rdott
Copy link
Contributor

@rdott rdott commented Aug 24, 2021

…and KeypressListener components

WHY are these changes introduced?

Updating existing tests to use the new modern framework and eliminate stale dependencies.

For the following component tests:

  • IndexTable
  • Indicator
  • InlineError
  • KeyboardKey
  • KeypressListener

WHAT is this pull request doing?

Part of test modernization, updating tests using {mountWithAppProvider} from 'test-utilities/legacy' to {mountWithApp} from 'test-utilities'

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2021

size-limit report

Path Size
cjs 143.11 KB (0%)
esm 96.81 KB (0%)
esnext 140.11 KB (0%)
css 33.96 KB (0%)

@rdott rdott marked this pull request as ready for review August 25, 2021 14:57
@rdott rdott requested review from a team, debchn and voiid August 25, 2021 14:57
@rdott rdott force-pushed the test-mod/indexTable branch from 704c8bd to 6f1a9a7 Compare August 25, 2021 21:28
@rdott rdott merged commit 133356d into main Aug 26, 2021
@rdott rdott deleted the test-mod/indexTable branch August 26, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants