Fix bugs discovered after skn build migration #4448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids an issue in webpack that uses different import semantics for js and mjs files This fixes our size-limit check
BPScott
changed the title
Member
Author
|
size-limit is breaking here, as it is failing to run against main, however the run against this branch works. Merging this shall mean main starts to work again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The migration to skn for our build in #4424 was bold.
So bold that I left some few silly bugs in it.
This PR fixes those bugs.
WHAT is this pull request doing?
size-limit.@sewing-kit/plugin-rollup