[TestModernization]: Add test modernization to Collapsible, Tabs and TextStyle #4453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
changed the title
ghost
marked this pull request as ready for review
Contributor
size-limit report
|
kyledurand
approved these changes
Sep 1, 2021
Member
kyledurand
left a comment
kyledurand
left a comment
There was a problem hiding this comment.
Looks awesome @kpinzas-sh! Thanks so much 😄
Free to ship as is but I'm super curious what the domNode.click is needed for because I've never had to use that. Also I'd expect click to be a function so it seems like it's not getting called 🤷♂️
| ); | ||
| expect(textStyle.find('span').text()).toBe('Hello Polaris'); | ||
| const textStyle = mountWithApp(<TextStyle>Hello Polaris</TextStyle>); | ||
| expect(textStyle.find('span')).toContainReactText('Hello Polaris'); |
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
I am updating existing tests for Collapsible, Tabs and TextStyle components to use the new modern framework. I worked with @rdott in solving several of the details here on those tests.
WHAT is this pull request doing?
Part of test modernization (https://docs.google.com/spreadsheets/d/1GBuEZbOpVYJLNISK7gL69DU8rCxocn5L5GYaKtPXPbU/edit#gid=1498187033), updating tests using {mountWithAppProvider} from 'test-utilities/legacy' to {mountWithApp} from 'test-utilities'.