Skip to content

Conversation

@sergical
Copy link

@sergical sergical commented Sep 1, 2021

Screen Shot 2021-09-01 at 2 49 01 PM

Screen Shot 2021-09-01 at 2 47 45 PM

WHY are these changes introduced?

An accessibility concern, previously loading screens would flicker with the animation enabled.

WHAT is this pull request doing?

Adding scoped css to disable animation when Reduce motion setting is turned on on user's system.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

  • Turn on Reduced motion setting in your System preferences
  • Load up storybook or consume in web
  • Check any loading skeleton screens to make sure they aren't animating the opacity

🎩 checklist

@sergical sergical force-pushed the reduce-motion-animation branch from e67e5dd to 5a7ade1 Compare September 1, 2021 18:56
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2021

size-limit report

Path Size
cjs 163.42 KB (0%)
esm 96.16 KB (0%)
esnext 143.03 KB (+0.03% 🔺)
css 34.52 KB (+0.13% 🔺)

@sergical sergical merged commit 505f5fd into main Sep 1, 2021
@sergical sergical deleted the reduce-motion-animation branch September 1, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants